Don't use a verified nullptr as a data source
ClosedPublic
Actions

Authored by leinir on Dec 12 2019, 3:12 PM.

Details

Reviewers

ronaldv
apol

Group Reviewers

Commits

Summary

Actually use some variables with usable information in version.h

Don't de-reference what will at this point definitely be a null ptr

Also use the information from version.h to perform the same task,
now that that information is, in fact, useful

Repository

R235 Attica

Branch

dont-use-null-qcoreapp-instance (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19752
Build 19770: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

leinir requested review of this revision.Dec 12 2019, 3:12 PM

This revision is now accepted and ready to land.Dec 15 2019, 9:46 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/provider.cpp (3 lines)
M			src/version.h.cmake (8 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71362	268195d		Dec 12 2019, 3:12 PM	★	★
Diff 2	71608	c9feef4	R235:5a379ba5a6cee366bf44cbe28dbef63eb1e150a3	Dec 15 2019, 4:02 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
178d840a513f	eb77c7b5e7b2	3bc86bfd989e	Dan Leinir Turthra Jensen	Don't de-reference what will at this point definitely be a null ptr (Show More…)	Dec 12 2019, 3:11 PM
3bc86bfd989e	5756497dc3e1	268195d2d5e2	Dan Leinir Turthra Jensen	Actually use some variables with usable information in version.h	Dec 12 2019, 3:11 PM