Differential D2591

[Task Manager ToolTipDelegate] Try harder to keep tooltip the same height
ClosedPublic
Actions

Authored by broulik on Aug 26 2016, 1:00 PM.

Details

Reviewers
mart
hein
Group Reviewers
Plasma
Commits
R119:c80062cc005d: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height
Summary

By reducing spacing and lineHeight for the heading in case of a two line heading we ensure the popup usually doesn't change height when moving between entries.

Spacing previously was "_s" which was equal to largeSpacing / 2 but during porting this was errorneously changed.

Test Plan

With multiple virtual desktops, hovered between:

  • A window with one line title
  • A window group
  • A window with two line title

and tooltip did not change its height

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 6297.Aug 26 2016, 1:00 PM
broulik retitled this revision from to [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 26 2016, 1:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Aug 26 2016, 1:31 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 26 2016, 1:31 PM
hein accepted this revision.Aug 26 2016, 4:30 PM
hein added a reviewer: hein.
Closed by commit R119:c80062cc005d: [Task Manager ToolTipDelegate] Try harder to keep tooltip the same height (authored by broulik). · Explain WhyAug 29 2016, 12:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6355

View Options

applets/taskmanager/package/contents/ui/ToolTipDelegate.qml

Loading...