Fix decrement index and not iterator as discussed with David
ClosedPublic
Actions

Authored by mlaurent on Dec 11 2019, 6:47 PM.

Details

Reviewers

dfaure
anthonyfieroni

Commits

Summary

Fix decrement index and not iterator

Repository

R320 KIO Extras

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent requested review of this revision.Dec 11 2019, 6:47 PM

anthonyfieroni added inline comments.

network/kded/kioslavenotifier.cpp
114	Same here

Fix other code

Ping ?:)

This revision is now accepted and ready to land.Dec 12 2019, 6:55 PM

We can thank Qt for deprecating QHash::iterator::operator-- which allowed Laurent to catch this :-)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			network/kded/kioslavenotifier.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	71312	d9239aa		Dec 11 2019, 6:47 PM	★	★
Diff 2	71322	d9239aa	Fix other code	Dec 11 2019, 8:45 PM	★	★
Diff 3	71392	4ec12a8	R320:6f1b8a6c61d86caf040fd5ca100ec359b6c28864	Dec 12 2019, 7:20 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
521f8746b90f	7c11a4dcfb49	d9239aa57780	Laurent Montel	Fix decrement index and not iterator as discussed with David (Show More…)	Dec 11 2019, 6:46 PM