Add 32, 48 and 64 px user-desktop icons
ClosedPublic

Authored by ndavis on Dec 11 2019, 5:47 PM.

Details

Summary

This prevents the icon from becoming blurry at fairly normal panel widths.

Test Plan

  • make/ninja install
  • rm -r ~/.cache/plasma*
  • plasmashell --replace &

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ndavis created this revision.Dec 11 2019, 5:47 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 11 2019, 5:47 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Dec 11 2019, 5:47 PM
ndavis edited the test plan for this revision. (Show Details)Dec 11 2019, 5:48 PM

Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO:

Thanks. However I wonder if the stroke width ought to increase for the larger sizes? Having such skinny lines looks a tad odd to me IMO:

If you look to the left, the other 32px icons also use lines that are that thin. The difference is that the desktop icon is so empty compared to the other icons. I don't know what to do about this TBH.

The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel grid. And most monochrome widgets have thicker lines when added to a tall panel:

This may be a side effect of scaling up smaller icons, but I think the thicker strokes work well for a large panel.

ndavis added a comment.EditedDec 13 2019, 7:15 PM

The straight lines in the system tray items from my screenshot are definitely 1px strokes. But all the curved lines look thicker by virtue of not being able to align to the pixel grid. And most monochrome widgets have thicker lines when added to a tall panel:

This may be a side effect of scaling up smaller icons, but I think the thicker strokes work well for a large panel.

ew, blurry icons :(

I think the icons in that screenshot are 32px scaled to 48px.

Perhaps line thickness could be increased for the 48 and 64px versions, but I do not think it should be increased for 32px. That would require us to make 32px icons less detailed than 22px icons because the effective space would be brought down to the level of 16px icons. Monochrome icons should not be highly detailed though, so the extra space is completely wasted on the 48 and 64 px versions.

ndavis updated this revision to Diff 71467.Dec 13 2019, 7:26 PM
  • increase line thickness for 48 and 64 px
ndavis edited the test plan for this revision. (Show Details)Dec 13 2019, 7:28 PM
ngraham accepted this revision.Dec 13 2019, 7:29 PM
This revision is now accepted and ready to land.Dec 13 2019, 7:29 PM
This revision was automatically updated to reflect the committed changes.