Differential D2587

Set proper component name for plasma-discover
ClosedPublic
Actions

Authored by bshah on Aug 26 2016, 11:10 AM.

Details

Reviewers
apol
graesslin
Group Reviewers
Plasma
Commits
R134:663b245051ad: Set proper component name for plasma-discover
Summary

Plasma discover installs desktop file as org.kde.discover, but it
instead sets its component name as muondiscover, and breaks the RDN
scheme.

this fixes window icon for discover

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bshah updated this revision to Diff 6290.Aug 26 2016, 11:10 AM
bshah retitled this revision from to Set proper component name for plasma-discover.
bshah updated this object.
bshah edited the test plan for this revision. (Show Details)
bshah added reviewers: Plasma, apol, graesslin.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 26 2016, 11:10 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah added a comment.Aug 26 2016, 11:28 AM
In D2587#48297, @apol wrote:

Are you sure it wasn't because of this?
http://commits.kde.org/discover/31ccc5d258a1833bc67a9af0ae8c9e70d951edd8

setWindowIcon doesn't work on wayland.. See - https://blog.martin-graesslin.com/blog/2015/07/porting-qt-applications-to-wayland/ "Setting window icon" section.

apol accepted this revision.Aug 26 2016, 11:59 AM
apol edited edge metadata.

I thought so.

This revision is now accepted and ready to land.Aug 26 2016, 11:59 AM
Closed by commit R134:663b245051ad: Set proper component name for plasma-discover (authored by bshah). · Explain WhyAug 26 2016, 12:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mdiscover/main.cpp (2 lines)

Diff 6295

View Options

discover/main.cpp

Loading...