Differential D25839

Compositor to suspend when plug in an monitor
Needs RevisionPublic
Actions

Authored by zccrs on Dec 10 2019, 11:02 AM.

Details

Reviewers
zzag
davidedmundson
Group Reviewers
KWin
Summary

when plug in an external display, there is a rare chance that GL_MAX_VIEWPORT_DIMS request returns with nothing, leaving limit uninitialized and wrong, which causes a subsequent compositing suspend.

Diff Detail

Repository
R108 KWin
Lint
Lint Skipped
Unit
Unit Tests Skipped
zccrs created this revision.Dec 10 2019, 11:02 AM
Restricted Application added a subscriber: kwin. · View Herald TranscriptDec 10 2019, 11:02 AM
zccrs requested review of this revision.Dec 10 2019, 11:02 AM
davidedmundson requested changes to this revision.Dec 10 2019, 2:11 PM
davidedmundson added a subscriber: davidedmundson.

That's a somewhat messy hack.

But it's a good investigation that this is wrong. Probably means we don't have an active GL context.

Can you get a backtrace of when we're in this method with it failing?

This revision now requires changes to proceed.Dec 10 2019, 2:11 PM
zccrs added a comment.Dec 11 2019, 1:40 AM
In D25839#574771, @davidedmundson wrote:

That's a somewhat messy hack.

But it's a good investigation that this is wrong. Probably means we don't have an active GL context.

Can you get a backtrace of when we're in this method with it failing?

In D25839#574771, @davidedmundson wrote:

That's a somewhat messy hack.

But it's a good investigation that this is wrong. Probably means we don't have an active GL context.

Can you get a backtrace of when we're in this method with it failing?

zccrs edited the summary of this revision. (Show Details)Dec 20 2019, 7:57 AM

Revision Contents
Changeset List

Diff 71169

View Options

plugins/scenes/opengl/scene_opengl.cpp

Loading...