Differential D25824

Support archive installs with adoption commands
ClosedPublic
Actions

Authored by leinir on Dec 9 2019, 5:57 PM.

Details

Reviewers
apol
ngraham
Group Reviewers
Frameworks
Plasma
KNewStuff
Commits
R304:709944d6cb5c: Support archive installs with adoption commands
Summary

This previously caused any icon pack installed through the store to
not function when the adoption command pointed at a directory rather
than a file.

BUG:407687

Test Plan

Previously: Using the "Use" option in either the Icons KCM or Discover with any icon pack would cause there to be no icon theme set

With patch: Correctly switches to the newly installed icon set

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Dec 9 2019, 5:57 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 9 2019, 5:57 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Dec 9 2019, 5:57 PM
leinir edited the test plan for this revision. (Show Details)Dec 9 2019, 6:00 PM
leinir added reviewers: Frameworks, Plasma, KNewStuff, apol, ngraham.
apol added inline comments.Dec 9 2019, 8:42 PM
src/core/engine.cpp
746–747

Shouldn't we make sure rootPath ends with /?
at least with an ASSERT if we know it's there.

leinir marked an inline comment as done.Dec 10 2019, 11:20 AM
leinir added inline comments.
src/core/engine.cpp
746–747

Hmm... It /should/ be done, but it's also not a bad thing to perform a touch of sanitising on this, so... yup, let's just do that, update incoming

leinir updated this revision to Diff 71173.Dec 10 2019, 11:21 AM
leinir marked an inline comment as done.
  • Ensure rootPath is definitely clean and has a / at the end
apol accepted this revision.Dec 10 2019, 12:52 PM
This revision is now accepted and ready to land.Dec 10 2019, 12:52 PM
Closed by commit R304:709944d6cb5c: Support archive installs with adoption commands (authored by leinir). · Explain WhyDec 10 2019, 1:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/engine.cpp (27 lines)

Diff 71185

View Options

src/core/engine.cpp

Loading...