Currently, the Tab key in 'Present Windows' has no effect. This patch provides a crude method to cycle through the available windows using Tab.
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
In principle I think this makes sense, but in practical usage, I find that it's much faster to use the existing arrow key navigation feature to navigate spatially between windows rather than tab-tab-tab-tab through them all until you find the right now. Thoughts?
My personal use case for this is mostly after typing to filter the windows, since there's usually only a couple at that point, so I wouldn't have to move my hand to the arrow keys. I agree in general the arrow keys are better especially when there's many windows open.
As far as I could tell there's no modifiers on any of the other keys, so I wasn't sure about behavior consistency for Shift-Tab
I think you can check for if Shift is also pressed in the handler for Qt::Key_Tab, or maybe there's a better way, but it can be done.
I also think offering Alt+Tab here as alternative makes sense.
Please adhere to code styling https://community.kde.org/Policies/Frameworks_Coding_Style
then it can get merged.
About code style, do you mean having braces around one line if statements? I tried to follow the surrounding code but should I just modify the rest of the file then?
Also, for Alt+Tab maybe it should function same as the Alt+Tab switcher so when it's released it automatically selects the highlighted window?