Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"
ClosedPublic

Authored by ngraham on Dec 6 2019, 7:06 PM.

Details

Summary

This is a bit clearer, and reinforces the keyboard icon used for the menu item.

BUG: 39488
FIXED-IN: 5.66

If accepted, will wait until after tagging to land it so as not to break the string freeze.

Test Plan

Diff Detail

Repository
R265 KConfigWidgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Dec 6 2019, 7:06 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 6 2019, 7:06 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 6 2019, 7:06 PM
ndavis added a subscriber: ndavis.Dec 6 2019, 7:11 PM

This doesn't seem wrong, but why is it needed? Do people get confused about the type of shortcuts? Are there non-keyboard shortcuts? If there are, would we put their configuration menu under a different menu option?

There was a bug report about it that had some people agreeing with it. I think it makes a bit of sense because yes, this dialog is indeed only about keyboard shortcuts, and at least to my ears, the phrase "keyboard shortcuts" instantly connotes what this is about, while "shortcuts" is a more generic term that doesn't have such an instantly recognizable computer-related meaning.

ndavis accepted this revision.Dec 6 2019, 7:43 PM

Welp, there's nothing objectively wrong with making this patch. LGTM

This revision is now accepted and ready to land.Dec 6 2019, 7:43 PM

Please commit it after the commit for the new Frameworks is made (so probably from Sunday onwards).

Yep, in fact I mentioned this in the description section of the patch:

If accepted, will wait until after tagging to land it so as not to break the string freeze.

Oh sorry, I missed that. It's the kind of information I wouldn't expect in the commit message.

This revision was automatically updated to reflect the committed changes.