Differential D25708

Don't use nullptr to flags
ClosedPublic
Actions

Authored by mlaurent on Dec 3 2019, 6:54 AM.

Details

Reviewers
romangg
zzag
Commits
R127:b3c7074431d0: Don't use nullptr to flags
Summary

IT seems that it was a error during modernize code by using nullptr
but it's a flags so we can't use it

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mlaurent created this revision.Dec 3 2019, 6:54 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 3 2019, 6:54 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Dec 3 2019, 6:54 AM
mlaurent added a reviewer: romangg.
zzag accepted this revision.Dec 3 2019, 8:22 AM
zzag added a subscriber: zzag.

IT seems that it was a error during modernize code by using nullptr

Yeah, we had the same issue with running modernize-use-nullptr over kwin's code base.

This revision is now accepted and ready to land.Dec 3 2019, 8:22 AM
Closed by commit R127:b3c7074431d0: Don't use nullptr to flags (authored by mlaurent). · Explain WhyDec 3 2019, 9:17 AM
This revision was automatically updated to reflect the committed changes.
aacid added a subscriber: aacid.Dec 3 2019, 11:14 AM

To be clear, that works just fine, it's just weird and deprecated on 5.15, but it's not "incorrect" code

Revision Contents
Changeset List

Diff 70811

View Options

src/client/xdgshell_stable.cpp

Loading...
View Options

src/client/xdgshell_v6.cpp

Loading...