Differential D25693

Port away from deprecated DesktopIcon
ClosedPublic
Actions

Authored by nicolasfella on Dec 2 2019, 8:32 PM.

Details

Reviewers
vkrause
Group Reviewers
Gwenview
Maniphest Tasks
T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API
Commits
R260:a6538c45ba7f: Port away from deprecated DesktopIcon
Summary

Use QIcon::fromTheme

Test Plan

Still get the stopwatch icon as thumbnail when thumbnail is loaded

Diff Detail

Repository
R260 Gwenview
Branch
di
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19403
Build 19421: arc lint + arc unit
nicolasfella created this revision.Dec 2 2019, 8:32 PM
Restricted Application added a project: Gwenview. · View Herald TranscriptDec 2 2019, 8:32 PM
nicolasfella requested review of this revision.Dec 2 2019, 8:32 PM
vkrause accepted this revision.Dec 3 2019, 8:02 AM
vkrause added a subscriber: vkrause.
vkrause added inline comments.
lib/thumbnailview/thumbnailview.cpp
390

btw, QIcon::pixmap exists in a single argument variant as well, so you don't have to repeat the size in the common case of a square icon :)

This revision is now accepted and ready to land.Dec 3 2019, 8:02 AM
nicolasfella updated this revision to Diff 70851.Dec 3 2019, 7:24 PM
  • Use single arg fucntion
Closed by commit R260:a6538c45ba7f: Port away from deprecated DesktopIcon (authored by nicolasfella). · Explain WhyDec 3 2019, 7:24 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella marked an inline comment as done.Dec 3 2019, 7:24 PM

Revision Contents
Changeset List

Diff 70775

View Options

lib/thumbnailview/thumbnailview.cpp

Loading...