Port to json metadata
ClosedPublic

Authored by nicolasfella on Sat, Nov 30, 4:15 PM.

Diff Detail

Repository
R150 KDE Telepathy KDE Daemon Module
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Sat, Nov 30, 4:15 PM
nicolasfella created this revision.
ltoscano added inline comments.
ktp_integration_module.json
3 ↗(On Diff #70623)

I can't comment on the rest of the reivew, but as you are changing this string, I think it would be worth to change the "with KDE" part (it comes from the old definition of KDE). Maybe the entire sentence needs to be re-though, I don't have a clear alternative right now.

Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem.

https://phabricator.kde.org/R871:498cd08a1956d557478b119aeed17fbfcfbd9b56

  • Use kcoreaddons_desktop_to_json
akulichalexandr accepted this revision.Tue, Dec 3, 11:46 PM
This revision is now accepted and ready to land.Tue, Dec 3, 11:46 PM
This revision was automatically updated to reflect the committed changes.