Details
Details
- Reviewers
akulichalexandr - Group Reviewers
Frameworks KDE Telepathy - Maniphest Tasks
- T11919: Port KDED modules from .desktop files to JSON metadata
- Commits
- R150:423c75cc12c3: Port to json metadata
Diff Detail
Diff Detail
- Repository
- R150 KDE Telepathy KDE Daemon Module
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
ktp_integration_module.json | ||
---|---|---|
3 ↗ | (On Diff #70623) | I can't comment on the rest of the reivew, but as you are changing this string, I think it would be worth to change the "with KDE" part (it comes from the old definition of KDE). Maybe the entire sentence needs to be re-though, I don't have a clear alternative right now. |
Comment Actions
Hi!
Thank you for taking this up.
Would you mind to use the same approach as in plasma-workspace? In case of your changes we'll lose the translations, but with desktop_to_json we won't have such a problem.
https://phabricator.kde.org/R871:498cd08a1956d557478b119aeed17fbfcfbd9b56