Fix i18n syntax to avoid runtime errors
ClosedPublic
Actions

Authored by ngraham on Nov 28 2019, 4:19 AM.

Details

Reviewers

Group Reviewers

Plasma
Frameworks

Commits

R304:dd5c9d461d86: Fix i18n syntax to avoid runtime errors

Summary

Using .arg() in i18n() calls can lead to runtime errors such as the ones shown in
https://bugs.kde.org/show_bug.cgi?id=414498. Let's port away from that.

BUG: 414498

Test Plan

QML GHNS dialog no longer has any i18n errors in strings

Repository

R304 KNewStuff

Branch

fix-i18n-usage (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 19238
Build 19256: arc lint + arc unit

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Nov 28 2019, 4:19 AM

...wow, ok, right, that's a fun bit of api difference right there ;) Thanks for those!

This revision is now accepted and ready to land.Nov 28 2019, 10:33 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/attica/atticaprovider.cpp (2 lines)
M			src/qtquick/qml/Dialog.qml (2 lines)
M			src/qtquick/qml/EntryDetails.qml (12 lines)
M			src/qtquick/qml/private/EntryCommentDelegate.qml (2 lines)
M			src/qtquick/qml/private/EntryCommentsPage.qml (2 lines)
M			src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml (4 lines)
M			src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml (4 lines)
M			src/qtquick/quickitemsmodel.cpp (2 lines)