Differential D25533

Deprecate KFileWidget::toolBar
ClosedPublic
Actions

Authored by nicolasfella on Nov 25 2019, 8:26 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Maniphest Tasks
T12206: Port KFileWidget away from KToolBar
Commits
R241:6973d4b26501: Deprecate KFileWidget::toolBar
Summary

It leaks KToolBar from KXmlGui into the public API. I did not find any code using it

Test Plan

builds

Diff Detail

Repository
R241 KIO
Branch
ktoolbar
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19305
Build 19323: arc lint + arc unit
nicolasfella created this revision.Nov 25 2019, 8:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 25 2019, 8:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 25 2019, 8:26 PM
dfaure requested changes to this revision.Nov 27 2019, 5:38 PM

5.65 isn't released yet, you can use 5.65 as deprecation version here.

This revision now requires changes to proceed.Nov 27 2019, 5:38 PM
nicolasfella updated this revision to Diff 70622.Nov 30 2019, 3:39 PM
  • Adjust version
dfaure added a comment.Dec 1 2019, 2:13 AM

I started a kdesrc-build with the method removed, and found that KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.

dfaure accepted this revision.Dec 2 2019, 10:22 PM

This patch itself is still correct though, of course.

This revision is now accepted and ready to land.Dec 2 2019, 10:22 PM
Closed by commit R241:6973d4b26501: Deprecate KFileWidget::toolBar (authored by nicolasfella). · Explain WhyDec 15 2019, 9:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70622

View Options

src/filewidgets/CMakeLists.txt

Loading...
View Options

src/filewidgets/kfilewidget.h

Loading...