Deprecate KFileWidget::toolBar
AcceptedPublic

Authored by nicolasfella on Mon, Nov 25, 8:26 PM.

Details

Reviewers
dfaure
Group Reviewers
Frameworks
Maniphest Tasks
T12206: Port KFileWidget away from KToolBar
Summary

It leaks KToolBar from KXmlGui into the public API. I did not find any code using it

Test Plan

builds

Diff Detail

Repository
R241 KIO
Branch
ktoolbar
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19305
Build 19323: arc lint + arc unit
nicolasfella created this revision.Mon, Nov 25, 8:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMon, Nov 25, 8:26 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Mon, Nov 25, 8:26 PM
dfaure requested changes to this revision.Wed, Nov 27, 5:38 PM

5.65 isn't released yet, you can use 5.65 as deprecation version here.

This revision now requires changes to proceed.Wed, Nov 27, 5:38 PM
  • Adjust version
dfaure added a comment.Sun, Dec 1, 2:13 AM

I started a kdesrc-build with the method removed, and found that KFileDialog::toolBar (in kdelibs4support) uses it, so it needs a matching #if in case EXCLUDE_DEPRECATED_BEFORE_AND_AT.

dfaure accepted this revision.Mon, Dec 2, 10:22 PM

This patch itself is still correct though, of course.

This revision is now accepted and ready to land.Mon, Dec 2, 10:22 PM