Differential D25528

Only build activities support if QtSQL is found
ClosedPublic
Actions

Authored by nicolasfella on Nov 25 2019, 3:53 PM.

Details

Reviewers
apol
Group Reviewers
Frameworks
Commits
R320:839fe1b51aea: Only build activities support if QtSQL is found
Summary

Check if QtSql is found before including the activities directory. Drop unneeded find_package calls

Test Plan

builds

Diff Detail

Repository
R320 KIO Extras
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Nov 25 2019, 3:53 PM
Restricted Application added projects: Dolphin, Frameworks. · View Herald TranscriptNov 25 2019, 3:53 PM
Restricted Application added subscribers: kfm-devel, kde-frameworks-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 25 2019, 3:53 PM
nicolasfella edited the summary of this revision. (Show Details)Nov 25 2019, 3:54 PM
nicolasfella edited the test plan for this revision. (Show Details)
nicolasfella added a reviewer: Frameworks.
apol added a subscriber: apol.Nov 25 2019, 4:32 PM

This patch is changing the logic. I'd recommend changing the commit message to reflect it.

CMakeLists.txt
150

I'd say it's better to use ...AND TARGET Qt5::Sql)

nicolasfella retitled this revision from [activities] Clean up cmake to Only build activities support if QtSQL is found.Nov 25 2019, 7:55 PM
nicolasfella updated this revision to Diff 70316.Nov 25 2019, 7:57 PM
  • Use if TARGET
apol accepted this revision.Nov 25 2019, 11:52 PM
This revision is now accepted and ready to land.Nov 25 2019, 11:52 PM
Closed by commit R320:839fe1b51aea: Only build activities support if QtSQL is found (authored by nicolasfella). · Explain WhyNov 25 2019, 11:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70321

View Options

CMakeLists.txt

Loading...
View Options

activities/CMakeLists.txt

Loading...
View Options

activities/fileitemplugin/CMakeLists.txt

Loading...