I copied them into Konqueror (the only user), after adding
namespacing there to avoid clashing with KBookmarks.
Details
Details
Builds with and without -DEXCLUDE_DEPRECATED_BEFORE_AND_AT=5.64.0
Diff Detail
Diff Detail
- Repository
- R294 KBookmarks
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 19092 Build 19110: arc lint + arc unit
Comment Actions
That should be upcoming 5.65 here though, not 5.64.
Moving things into visibility-protection guards of recent versions will break things for people who used DISABLE_DEPRECATED_BEFORE_AND_AT after having properly checked their source is properly building against released versions with the value used for that flag. See also https://mail.kde.org/pipermail/kde-frameworks-devel/2019-November/096701.html
(Edit: in this case possibly not that much relevant, as Konqueror might be the only user. Yet, there is no need to make this 5.64, right? So let's do it properly, to not mislead other people looking for samples how to do deprecation)
Comment Actions
Oops the next version is 65, not 64.
You'd think *I* would know that... :-)
Yes I did mean "next version", I just picked the wrong number.
Comment Actions
Seems fine by pure patch reading.
| src/konqbookmarkmenu.h | ||
|---|---|---|
| 51 | Should also be noted in the API dox with a @since, for good example purpose. Actually best to be done in the class API dox, though KonqBookmarkMenu does not have one yet (and thus also not picked up by kapidox/ecm_add_qch doxygen usage). So would just add to both constructors' API dox. | |