Cleanup DBus-related resources before qApp exits
AbandonedPublic

Authored by kfunk on Aug 23 2016, 8:41 AM.

Details

Reviewers
vonreth
dfaure
Summary

... to avoid deadlocks with the DBus thread on Windows.

Related to D1909

CCBUG: 366596

Test Plan

All but one test succeeded (but this one also failed before):

The following tests FAILED:

22 - kiogui-favicontest (OTHER_FAULT)

Diff Detail

Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
kfunk updated this revision to Diff 6174.Aug 23 2016, 8:41 AM
kfunk retitled this revision from to Cleanup DBus-related resources before qApp exits.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
kfunk edited the test plan for this revision. (Show Details)Aug 23 2016, 8:42 AM
kfunk added reviewers: dfaure, vonreth.
kfunk added a subscriber: Frameworks.
dfaure edited edge metadata.Sep 8 2016, 9:14 PM

Same as in https://phabricator.kde.org/D2545, I think this should be fixed in Qt instead. At least let's see what Thiago says.

Since there is no fix on Qt, should we merge this?

dfaure accepted this revision.Nov 29 2016, 5:29 PM
dfaure edited edge metadata.
This revision is now accepted and ready to land.Nov 29 2016, 5:29 PM
kfunk abandoned this revision.Jan 17 2017, 7:35 AM

Patched Qt instead:

https://phabricator.kde.org/R138:7f78f7297add7c510c1cf0f1707197c8c403fcee

I can't make my mind up how to fix this cleanly, to be honest.