Differential D25442

Set application name and version on the knshandler tool
ClosedPublic
Actions

Authored by leinir on Nov 21 2019, 4:19 PM.

Details

Reviewers
starbuck
apol
Group Reviewers
Frameworks
Plasma
Commits
R252:06bd561dceb1: Set application name and version on the knshandler tool
Summary

In preparation for D25441 and D25440 being merged, this patch would
allow for some granular-but-anonymous investigation of where heavy
pressure on the store server is coming from

Diff Detail

Repository
R252 Framework Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Nov 21 2019, 4:19 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 21 2019, 4:19 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Nov 21 2019, 4:19 PM
apol accepted this revision.Nov 22 2019, 11:05 AM
apol added a subscriber: apol.

Is the store having a big impact from this handler?

This revision is now accepted and ready to land.Nov 22 2019, 11:05 AM
leinir added a comment.Nov 22 2019, 11:11 AM

Thanks :)

In D25442#566050, @apol wrote:

Is the store having a big impact from this handler?

We think it might very possibly - specifically, look and feel is under suspicion, but... suspicions are just that without proof, and being able to work it out properly is just handy in general :)

Closed by commit R252:06bd561dceb1: Set application name and version on the knshandler tool (authored by leinir). · Explain WhyNov 22 2019, 11:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 70148

View Options

src/kpackage-install-handlers/kns/CMakeLists.txt

Loading...
View Options

src/kpackage-install-handlers/kns/knshandlerversion.h.in

Loading...
View Options

src/kpackage-install-handlers/kns/main.cpp

Loading...