Differential D25377

Don't covert icons to pixmaps multiple times
ClosedPublic
Actions

Authored by nicolasfella on Nov 18 2019, 7:36 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Ark
Commits
R36:81828188101f: Don't covert icons to pixmaps multiple times
Summary

We don't need to convert the icon which is loaded by name to a pixmap here. The conversion happens later in the DecorationRole data() call.

Test Plan

Open archive. Icons in the file list appear and are properly sized.
Trigger overwrite dialog. Icons appear and are properly sized.

Verified performance improvement with hotspot (see highlighted entries)

before:

after:

Diff Detail

Repository
R36 Ark
Branch
conv
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18917
Build 18935: arc lint + arc unit
nicolasfella created this revision.Nov 18 2019, 7:36 PM
Restricted Application added a project: Ark. · View Herald TranscriptNov 18 2019, 7:36 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
nicolasfella requested review of this revision.Nov 18 2019, 7:36 PM
nicolasfella edited the test plan for this revision. (Show Details)Nov 18 2019, 7:42 PM
This revision is now accepted and ready to land.Nov 18 2019, 8:47 PM
Closed by commit R36:81828188101f: Don't covert icons to pixmaps multiple times (authored by nicolasfella). · Explain WhyNov 18 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mpart/archivemodel.cpp (6 lines)

Diff 69950

View Options

part/archivemodel.cpp

Loading...