Don't covert icons to pixmaps multiple times
Summary: We don't need to convert the icon which is loaded by name to a pixmap here. The conversion happens later in the DecorationRole data() call.
Test Plan:
Open archive. Icons in the file list appear and are properly sized.
Trigger overwrite dialog. Icons appear and are properly sized.
Verified performance improvement with hotspot (see highlighted entries)
before:
after:
Reviewers: Ark, elvisangelaccio
Reviewed By: Ark, elvisangelaccio
Subscribers: elvisangelaccio, kde-utils-devel
Tags: Ark
Differential Revision: https://phabricator.kde.org/D25377