Diffusion Ark 81828188101f

Don't covert icons to pixmaps multiple times

Authored by nicolasfella on Nov 18 2019, 7:33 PM.

Description

Don't covert icons to pixmaps multiple times

Summary: We don't need to convert the icon which is loaded by name to a pixmap here. The conversion happens later in the DecorationRole data() call.

Test Plan:
Open archive. Icons in the file list appear and are properly sized.
Trigger overwrite dialog. Icons appear and are properly sized.

Verified performance improvement with hotspot (see highlighted entries)

before:

after:

Reviewers: Ark, elvisangelaccio

Reviewed By: Ark, elvisangelaccio

Subscribers: elvisangelaccio, kde-utils-devel

Tags: Ark

Differential Revision: https://phabricator.kde.org/D25377

Details

Committed
nicolasfellaNov 18 2019, 10:50 PM
Reviewer
Ark
Differential Revision
D25377: Don't covert icons to pixmaps multiple times
Parents
R36:cce9aac9f3bc: Merge branch 'release/19.12'
Branches
Unknown
Tags
Unknown