[ResultDelegate] Fix bad text legiblity with certain 3rd party themes

Authored by filipf on Nov 18 2019, 5:45 PM.



This is a fix for D25043.

Using disabledTextColor results in bad text legibility with Plasma themes that use filled-style highlight effects.

If colors are prefered over opacity as means of achieving text shading then we need to mix disabledTextColor with textColor on selection.

This creates an effect that is comparable to the opacity: isCurrent? 0.8 : 0.6 code that is used throughout Plasma for subtitles.

Test Plan

Only test with master.

Arc Color (before):

Arc Color (after):

McMojave (before):

McMojave (after):

Breeze (before):

Breeze (after):

Breeze Dark (before):

Breeze Dark (after):

Diff Detail

R112 Milou
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Nov 18 2019, 5:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 18 2019, 5:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Nov 18 2019, 5:45 PM
filipf edited the summary of this revision. (Show Details)Nov 18 2019, 5:48 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: Plasma, VDG.

This makes it quite hard to read on a dark background here

It should be lighter in the case of dark themes, that's what I get empirically and what the code points to. How do I reproduce this?

ngraham accepted this revision.Dec 14 2019, 1:27 PM
ngraham added a subscriber: ngraham.

Works for me, and the code looks like it's doing the right thing. Did you kill and relaunch krunner?

This revision is now accepted and ready to land.Dec 14 2019, 1:27 PM

IIRC Kai told me in person that this was okay, but let's wait for official confirmation.

broulik accepted this revision.Dec 31 2019, 3:42 PM
This revision was automatically updated to reflect the committed changes.