| ngraham | |
| broulik |
| Plasma | |
| VDG |
This is a fix for D25043.
Using disabledTextColor results in bad text legibility with Plasma themes that use filled-style highlight effects.
If colors are prefered over opacity as means of achieving text shading then we need to mix disabledTextColor with textColor on selection.
This creates an effect that is comparable to the opacity: isCurrent? 0.8 : 0.6 code that is used throughout Plasma for subtitles.
Only test with master.
Arc Color (before):
Arc Color (after):
McMojave (before):
McMojave (after):
Breeze (before):
Breeze (after):
Breeze Dark (before):
Breeze Dark (after):
| No Linters Available |
| No Unit Test Coverage |
| Buildable 18914 | |
| Build 18932: arc lint + arc unit |
It should be lighter in the case of dark themes, that's what I get empirically and what the code points to. How do I reproduce this?
Works for me, and the code looks like it's doing the right thing. Did you kill and relaunch krunner?
IIRC Kai told me in person that this was okay, but let's wait for official confirmation.
