Differential D25310

Use the right value of EnableMagicMimeActions
ClosedPublic
Actions

Authored by trmdi on Nov 14 2019, 5:58 PM.

Details

Reviewers
ngraham
apol
Group Reviewers
Plasma
Commits
R120:895e31d6946b: Use the right value of EnableMagicMimeActions
Summary

BUG: 409801

Test Plan

The bug is fixed.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trmdi created this revision.Nov 14 2019, 5:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptNov 14 2019, 5:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Nov 14 2019, 5:58 PM
ngraham accepted this revision.Nov 14 2019, 8:56 PM
ngraham added a subscriber: ngraham.

Seems sensible to implement this the way reading all the other actions are implemented. Plasma people, is this okay?

This revision is now accepted and ready to land.Nov 14 2019, 8:56 PM
trmdi added a reviewer: apol.Nov 15 2019, 2:17 AM
davidedmundson added a subscriber: davidedmundson.Dec 4 2019, 5:09 PM

I can't really object, as you're just following the existing code, but I don't really understand why we're doing this.

klipper/urlgrabber.cpp
106

if (!KlipperSettings::enableMagicMimeActions())

without any other changes would do the same thing and be just as fast. The KConfigSkeletonItem keeps the value locally without reading every time.

trmdi added a comment.Dec 4 2019, 5:40 PM
This comment was removed by trmdi.
trmdi updated this revision to Diff 70933.Dec 5 2019, 3:31 AM

Remove unneeded code

Closed by commit R120:895e31d6946b: Use the right value of EnableMagicMimeActions (authored by trmdi, committed by ngraham). · Explain WhyDec 5 2019, 3:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mklipper/urlgrabber.cpp (3 lines)

Diff 70934

View Options

klipper/urlgrabber.cpp

Loading...