Remove flow, not needed since karbon can do it all
ClosedPublic

Authored by danders on Nov 11 2019, 11:59 AM.

Details

Summary

Since karbon is multipage app and stencils docker can be used by all apps,
there is no need for flow anymore.

Removing flow also 'fixes' problem with filter system, as it does not
know which app to open when two apps handle the same mimetype.

Test Plan

Tested with visio files.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
danders created this revision.Nov 11 2019, 11:59 AM
Restricted Application added a project: Calligra: 3.0. · View Herald TranscriptNov 11 2019, 11:59 AM
Restricted Application added a subscriber: Calligra-Devel-list. · View Herald Transcript
danders requested review of this revision.Nov 11 2019, 11:59 AM

I'm unsure about that, if some people still prefer using Flow will make this change superfluous. I can't make decision about this changes, if you think it should be done - i'm fine.

Yeah, well.
If flow had some special functionallity that made it much easier to crate flow charts, I would also be reluctant to just remove it.
As it stands flow has nothing special, it is only a few line of code actually, and as I see it, the karbon ui is very similar to flow.
Granted, karbon can do a lot more, but I don't think it is disturibing the user as this is 'hidden' in separate menus.

Also, on a technical note, having two apps that handle the same mimetype (they are using the odg file format both) confuses the filter system.
E.g: You might try to open an svg file in karbon, but it might be opened in flow. In this case the only thing you can do as is to uninstall flow.

If you look to LO, they just use their regular draw app for flow charts too.

Now, if there was sombody that was interested in creating a fantastic flow app and maintaining it, maybe it should stay, but...

In short, I don't see any good reason to keep it.

Let's other members leave their opinion as well. I don't want to have surprised people by removing Flow.

To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow.

So I'm okay with it

To be honest I kind of liked the idea of a dedicated flow drawing tool and a dedicated vector drawing tool, but since they have so little between them, and no one seem to be maintaining flow.

Yes, I agree.
It is however, a problem having two apps using same native mimetype for realy different content.
I would certainly think it was worth it if flow had really good support for flow charts,
but it is really just the minimum needed to create a pageapp.
All functionallity is in the plugins, so flow does not offer any advantage over karbon or words.

I'll let this patch rest fttb, a decission can be made closer to next release.

I'm fine with your decision, just i don't want to be the only person accepted such a change.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2020, 6:58 AM
This revision was automatically updated to reflect the committed changes.