The index color filter currently only generates a custom palette. This patch adds the ability to have it use a kocolorset or a koabstractgradient as a palette source, potentially reducing time on the user's part configuring things.
Details
Details
Diff Detail
Diff Detail
- Repository
- R37 Krita
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Probably, it would be a good idea just to save/load the selected colors in the Custom tab to a KoColorSet? Is it too complicated?
Comment Actions
Well, the custom tab was the original gui. It was already there and I feel hesitant changing any of it till my brain works :p
Comment Actions
I don't know the code, so I cannot say much. Please always use QString() in favor of "".
plugins/filters/indexcolors/kiswdgindexcolors.cpp | ||
---|---|---|
202 | Please use QString() instead of "". It uses less memory and is faster to construct since it will just be a shared null. | |
plugins/filters/indexcolors/kiswdgindexcolors.h | ||
62 | are these members deleted again somewhere? I'm unsure about the memory management. it's a bit hard to read since the diff seems somehow limited (context not available). |