Show a "Loading more..." busy indicator when loading view data
ClosedPublic

Authored by leinir on Thu, Nov 7, 3:31 PM.

Details

Summary

Add an isFetching property to the QML ItemsModel, and use that
to show a busy indicator with a label at the end of the view
of entries when scrolling through it. This ensures the user is
informed when fetching is happening, without being too in-your-
face about it all.

Also remove the passive notifications for busy messages:
Since all the busy messages are for the model, and we now have a
different way to show this to the user, get rid of that one.
We still have a number of idle messages and other such informational
bits, but this gets rid of a great many of the more obnoxious
messages that keep popping up.

Test Plan

Without patch: A bunch of passive notifications when scrolling through the list, and on first start
With patch: Much fewer of the status-ey messages, and a generally more pleasant feel to the scrolling

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
leinir created this revision.Thu, Nov 7, 3:31 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptThu, Nov 7, 3:31 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
leinir requested review of this revision.Thu, Nov 7, 3:31 PM
leinir updated this revision to Diff 69398.Thu, Nov 7, 3:36 PM
  • Add some @since

Cool, I'm okay with that.

The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is.

Cool, I'm okay with that.

The "Loading more" indicator is aligned to the top, not centered like the other loading indicator is.

It's at the end of the list, though... perhaps it'd make sense to do a thing and ensure the item is the height of the view if there's no items in the list (which i think is what you're seeing)

leinir updated this revision to Diff 69428.Fri, Nov 8, 10:47 AM
  • Ensure that the indicator is the full height of the view when it's empty
ngraham accepted this revision.Fri, Nov 8, 2:30 PM
This revision is now accepted and ready to land.Fri, Nov 8, 2:30 PM
This revision was automatically updated to reflect the committed changes.