Add rotate and rotation-reset buttons to overview docker.
Needs ReviewPublic
Actions

Authored by woltherav on Aug 21 2016, 2:13 PM.

Details

Reviewers

dkazakov
rempt

Summary

I... vaguely recall there was a wishbug that assigned this to me... But I am pretty sure that there's a bug out there that needed this.

Anyway, adds buttons for rotate-right/reset rotation/rotate-left to the overview docker, to increase discoverability.

Test Plan

For some reason the icons don't show up.
Also we have no icon for resetRotation.

I don't know why the first happens, so hence the review request.

Repository

R37 Krita

Lint

Lint Skipped

Unit

Unit Tests Skipped

woltherav retitled this revision from to Add rotate and rotation-reset buttons to overview docker..

woltherav updated this object.

woltherav edited the test plan for this revision. (Show Details)

woltherav set the repository for this revision to R37 Krita.

woltherav added a project: Krita.

woltherav added a subscriber: timotheegiet.

Hi, Wolthera!

For some reason I don't see any icons on the new buttons :( Probably, the icons should be set on the actions instead of the buttons (just a guess)?

Yeah, that was my problem as well. But yes, perhaps using the action instead might be a good idea to try...

Um... Did we completely miss this patch, or did it land?

			Path	Packages
M			plugins/dockers/overview/overviewdocker_dock.h (6 lines)
M			plugins/dockers/overview/overviewdocker_dock.cpp (59 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	6117			Aug 21 2016, 2:07 PM	★	★