Differential D25151

Fix tabs not indicating activity
ClosedPublic
Actions

Authored by velan on Nov 5 2019, 7:08 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:69a8a99d15ee: Fix tabs not indicating activity
Summary

This fixes the bug with tabs not indicating terminal activity.
When the tab is split and has multiple child terminals, activity in any
of the child terminals will be indicated.

BUG: 406828
FIXED-IN: 19.12.0

Test Plan

Open two tabs, run sleep 2 in the first one and switch to the other.
After the sleep ends, the tab activity is indicated just as it was before
the bug was introduced.

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
velan requested review of this revision.Nov 5 2019, 7:08 AM
velan created this revision.
nucleo added a subscriber: nucleo.Nov 6 2019, 8:12 PM
anthonyfieroni added a subscriber: anthonyfieroni.Nov 7 2019, 8:47 AM

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

mglb retitled this revision from Fix bug 406828 to Indicate activity on tabs with splits.Nov 7 2019, 2:07 PM
mglb edited the test plan for this revision. (Show Details)
hindenburg retitled this revision from Indicate activity on tabs with splits to Fix tabs not indicating activity.Nov 7 2019, 2:14 PM
hindenburg edited the summary of this revision. (Show Details)
hindenburg edited the test plan for this revision. (Show Details)
hindenburg added a subscriber: hindenburg.Nov 7 2019, 2:35 PM

Sorry I didn't see your changes before I did mine.

hindenburg accepted this revision.Nov 7 2019, 3:05 PM
In D25151#559473, @anthonyfieroni wrote:

I see it in line above, but using qobject_cast and not checking for nullptr is waste of time, say if you're sure in type use static_cast, if not check result of qobject_cast against nullptr.

This line is used a number of times and can be fixed afterwards.

This revision is now accepted and ready to land.Nov 7 2019, 3:05 PM
hindenburg closed this revision.Nov 7 2019, 3:08 PM
hindenburg added a comment.EditedJan 3 2020, 2:10 AM

This appears to have caused this bug https://bugs.kde.org/show_bug.cgi?id=415249

ignore this

Revision Contents
Changeset List

PathPackages
Msrc/ViewContainer.cpp (4 lines)

Diff 69299

View Options

src/ViewContainer.cpp

Loading...