[Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication
ClosedPublic

Authored by filipf on Mon, Nov 4, 11:33 PM.

Details

Summary

Icon view currently sets a dialog-warning emblem on the sidebar icons for KCMs that require root authentication (SDDM, KDE Wallet).

This overlay is both confusing and unnecessary given that we already spell it out in big letters in the KCM header that we'll be asking for authentication.

This patch removes the icon overlay.

BUG: 413183
FIXED-IN: 5.17.3

Test Plan

Before:

After:

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Mon, Nov 4, 11:33 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Nov 4, 11:33 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Mon, Nov 4, 11:33 PM
filipf edited the summary of this revision. (Show Details)Mon, Nov 4, 11:34 PM
filipf edited the test plan for this revision. (Show Details)
filipf added reviewers: VDG, ngraham.

Might also be worth mentioning this now makes it consistent with sidebar view, which doesn't use this emblem.

ngraham accepted this revision.Mon, Nov 4, 11:42 PM
This revision is now accepted and ready to land.Mon, Nov 4, 11:42 PM

Would this be an acceptable change for the 5.17 branch?

I think so. This is a bugfix.

I think so. This is a bugfix.

OK, I'll land this there then (once the repo gets unbroken).

ndavis accepted this revision.Tue, Nov 5, 4:32 AM
filipf edited the summary of this revision. (Show Details)Tue, Nov 5, 10:54 AM
This revision was automatically updated to reflect the committed changes.