Differential D2515

Remove unused property
ClosedPublic
Actions

Authored by davidedmundson on Aug 21 2016, 11:38 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R871:70fa8ac292f5: Sync KSplash layout from SDDM mockup
R120:70fa8ac292f5: Sync KSplash layout from SDDM mockup
Summary

Sync KSplash layout from SDDM mockup

Test Plan

ksplashqml --test

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 6110.Aug 21 2016, 11:38 AM
davidedmundson retitled this revision from to Remove unused property.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptAug 21 2016, 11:38 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik added a subscriber: broulik.Aug 21 2016, 11:42 AM

Don't you need plasma core for units? I thought we didn't want to pull that in for startup time of the splash.

lookandfeel/contents/splash/Splash.qml
46

This doesn't make sense, you bind the thing to itself.

davidedmundson added a comment.Aug 21 2016, 11:44 AM
In D2515#47036, @broulik wrote:

Don't you need plasma core for units? I thought we didn't want to pull that in for startup time of the splash.

That's why I dont' pull it in.
There's a QFontMetrics item call unit. Line 43

davidedmundson updated this revision to Diff 6113.Aug 21 2016, 11:52 AM

Fixing fixing fixing

mart accepted this revision.Aug 22 2016, 8:56 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Aug 22 2016, 8:56 AM
Closed by commit R120:70fa8ac292f5: Sync KSplash layout from SDDM mockup (authored by davidedmundson). · Explain WhyAug 22 2016, 10:48 AM
This revision was automatically updated to reflect the committed changes.
broulik added inline comments.Aug 22 2016, 12:25 PM
lookandfeel/contents/splash/Splash.qml
47

The logo is initially visible and then animates back in now that you lost the opacity: 0

Revision Contents
Changeset List

Diff 6136

View Options

lookandfeel/contents/splash/Splash.qml

Loading...