Allow users to disable bird view
Needs RevisionPublic

Authored by juchatycapelle on Sat, Nov 2, 7:06 AM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Gwenview
Summary

The bird view is actually displayed over the content of the image when the image is zoomed in. While this is a useful feature it can in some circumstances be a problem for the user. For example this is annoying when reading comics.

This patch adds an option to the configuration panel to disable the bird view.

related to feature request BUG 413697

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
juchatycapelle created this revision.Sat, Nov 2, 7:06 AM
Restricted Application added a project: Gwenview. ยท View Herald TranscriptSat, Nov 2, 7:06 AM
juchatycapelle requested review of this revision.Sat, Nov 2, 7:06 AM
ngraham requested changes to this revision.Sat, Nov 2, 7:56 PM
ngraham added a reviewer: VDG.
ngraham added a subscriber: ngraham.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view:

That needs to be fixed at the minimum. Also, please refer to this thie feature/setting as "Bird's eye view."

In the future, when submitting patches that change the user interface, please make sure to add a screenshot or video to the Test Plan section, and add VDG as a reviewer.

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

This revision now requires changes to proceed.Sat, Nov 2, 7:56 PM
ndavis added a subscriber: ndavis.Sat, Nov 2, 8:36 PM

I'm not necessarily opposed to this, but Gwenview's Image View settings page is already quite cluttered with options. I wonder if there is a better way to toggle this on or off. Perhaps the checkbox could be located in the toolbar below the image view, or in a new overflow menu button we could add on the right side of that toolbar.

Alternatively, if living in the Image View page makes the most sense, we should probably condense the view by replacing some or all of those multi-item radio buttons with comboboxes, which will save a lot of space.

Thoughts, VDG folks?

I assume that this patch is for controlling this floating thumbnail:

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Yes, that's an excellent idea.

Thanks for the patch! The functionality seems to work fine. However it appears to cause a layout repression in the settings view

Oops ! I forgot to increment some row numbers, I checked a little bit quickly.

Maybe it could be an option in the View menu? This seems like something people may want to toggle on and off with a keyboard shortcut (remembering the state from previous instances) rather than opening the settings dialog to enable/disable.

Let's do this.