Differential D2510

Update to non-deprecated QStyleOptionViewItem class
ClosedPublic
Actions

Authored by martinkostolny on Aug 20 2016, 10:04 PM.

Details

Reviewers
asensi
gengisdave
Group Reviewers
Krusader
Commits
R167:ad6343fff743: Update to non-deprecated QStyleOptionViewItem class
Summary

QStyleOptionViewItemV4 was deprecated since Qt 5.7. I think we can safely update to this unversioned class replacement. Some time ago KIO guys have done that, too: https://git.reviewboard.kde.org/r/128208/

Test Plan
  • compile
  • play with files and folders in panel with brief-view enabled

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
martinkostolny updated this revision to Diff 6101.Aug 20 2016, 10:04 PM
martinkostolny retitled this revision from to Update to non-deprecated QStyleOptionViewItem class.
martinkostolny updated this object.
martinkostolny edited the test plan for this revision. (Show Details)
martinkostolny added a reviewer: Krusader.
martinkostolny set the repository for this revision to R167 Krusader.
martinkostolny added a project: Krusader.
gengisdave accepted this revision.Aug 21 2016, 9:56 AM
gengisdave added a reviewer: gengisdave.
This revision is now accepted and ready to land.Aug 21 2016, 9:56 AM
asensi accepted this revision.Aug 22 2016, 9:19 PM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Everything that was tried using Kubuntu 16.04 was seen the same way as before. Thanks Martin!

Closed by commit R167:ad6343fff743: Update to non-deprecated QStyleOptionViewItem class (authored by martinkostolny). · Explain WhyAug 22 2016, 11:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6165

View Options

krusader/Panel/krinterbriefview.cpp

Loading...
View Options

krusader/Panel/krviewitemdelegate.cpp

Loading...