Show info file content on the Step Context info docker
AbandonedPublic

Authored by yurchor on Thu, Oct 31, 8:10 PM.

Details

Reviewers
None
Group Reviewers
KDE Edu
Summary

The info browser data cannot be shown now. Console output is something like "Could not open help file at location: ":/objectinfo/world.html"".

This patch tries to solve the problem.

Test Plan
  1. Compile and install Step.
  2. Run Step using some of the translated locales (de, it, ru, uk) or the default locale. The context info should be shown for all objects, except SoftBody.

Step window with context help translated (patched version, Ukrainian (uk) locale)

Diff Detail

Repository
R341 Step
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18406
Build 18424: arc lint + arc unit
yurchor created this revision.Thu, Oct 31, 8:10 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptThu, Oct 31, 8:10 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Thu, Oct 31, 8:10 PM
yurchor edited the test plan for this revision. (Show Details)Fri, Nov 15, 12:29 PM
aacid added a subscriber: aacid.Mon, Nov 18, 8:09 PM

Where are the translated files at?

l10n svn?

Where are the translated files at?

l10n svn?

Yes. For example, the Italian ones are here:

https://websvn.kde.org/trunk/l10n-kf5/it/data/kdeedu/step/

These files are packaged by major distributions. Example:

https://packages.debian.org/sid/amd64/step/filelist

aacid added a comment.Mon, Nov 18, 9:02 PM

I'm curious, do you really not see the existing info and get an error?

It works fine just here (no i18n)

The files should end up inside a qrc file.

They are actually not installed as far as i can see so your code would not work at all.

Where do you see the english objinfo files being installed? http://paste.debian.net/1116844/

I'm curious, do you really not see the existing info and get an error?

It works fine just here (no i18n)

The files should end up inside a qrc file.

They are actually not installed as far as i can see so your code would not work at all.

Where do you see the english objinfo files being installed? http://paste.debian.net/1116844/

I do not know how it was thought to be. Just several facts from the current situation.

  1. Sure, the English HTML objinfo files are packaged into the step binary itself.
  2. The same HTML files are packaged separately as it can be seen from the Debian package file list. Thus, they are "installed" for every common *NIX user (not sure about Windows).
  3. The translation system for tutorials and world object files is unfinished. Extraction can be fixed almost with no efforts (tested). Just move the content of Messages.sh from step/data into the main Messages.sh and you are done.
  4. However, I'm not sure that translation will work after that.
  5. The proposed solution works fine with Linux packages. As it is shown above, it works for the standard Mageia package. It might not work for Windows or flatpack. But we do not have Windows package now and flatpacks are... well, for enthusiasts.

If somebody confirms that the current translation system works fine with MOs I'd be more than happy to propose the conventional patch for extraction.

aacid added a comment.Mon, Nov 18, 9:41 PM

The proposed solution works fine with Linux packages.

No it doesn't, the "english" filenames are not installed anymore.

The proposed solution works fine with Linux packages.

No it doesn't, the "english" filenames are not installed anymore.

Why? Please read the list for the Debian package:

https://packages.debian.org/sid/amd64/step/filelist

Citation:

/usr/share/step/objinfo/Anchor.html
/usr/share/step/objinfo/Box.html
/usr/share/step/objinfo/ChargedParticle.html
/usr/share/step/objinfo/CoulombForce.html
/usr/share/step/objinfo/Disk.html
/usr/share/step/objinfo/Gas.html
/usr/share/step/objinfo/GasLJForce.html
/usr/share/step/objinfo/GasParticle.html
/usr/share/step/objinfo/GravitationForce.html
/usr/share/step/objinfo/LinearMotor.html
/usr/share/step/objinfo/Meter.html
/usr/share/step/objinfo/Note.html
/usr/share/step/objinfo/Particle.html
/usr/share/step/objinfo/Pin.html
/usr/share/step/objinfo/Polygon.html
/usr/share/step/objinfo/Spring.html
/usr/share/step/objinfo/WeightForce.html
/usr/share/step/objinfo/World.html

Yes, that's the 19.08 package, not the 19.11 packages, just run make install yourself and see it

yurchor abandoned this revision.Tue, Nov 19, 6:53 AM

Yes, that's the 19.08 package, not the 19.11 packages, just run make install yourself and see it

Right. There should be some other solution...