kconfig_compiler: Move the KSharedConfig::Ptr when using them
ClosedPublic

Authored by aacid on Oct 29 2019, 9:59 PM.

Details

Summary

The generated classes of kconfig_compiler take a KSharedConfig::Ptr by
value, one possibility would be to make them const & but that is BIC so
instead what we do is just move them to the only place the config is
used so the cheaper move constructor can be used instead of the copy
constructor

Diff Detail

Repository
R237 KConfig
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18332
Build 18350: arc lint + arc unit
aacid created this revision.Oct 29 2019, 9:59 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 29 2019, 9:59 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Oct 29 2019, 9:59 PM
ervin accepted this revision.Oct 30 2019, 7:16 AM

LGTM, maybe give some times to others to chip in.

This revision is now accepted and ready to land.Oct 30 2019, 7:16 AM
apol accepted this revision.Oct 30 2019, 2:06 PM
aacid closed this revision.Oct 30 2019, 6:23 PM