feat(kcm): zoom preview automatically
AbandonedPublic

Authored by davidedmundson on Mon, Oct 28, 11:47 PM.

Details

Summary

On output size and position changes reset the relative output position in the
overview automatically.

This way the outputs are always movable with ease and the "center view" button
is not necessary anymore.

Test Plan

Moved outputs in multi monitor environment. Overview zoomed automatically.

Diff Detail

Repository
R104 KScreen
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Mon, Oct 28, 11:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 28, 11:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Mon, Oct 28, 11:47 PM
ngraham added inline comments.
kcm/package/contents/ui/Screen.qml
67

You don't need a Row here anymore because it now only contains one item; instead you can just position the Identify button manually.

romangg added inline comments.Tue, Oct 29, 5:32 PM
kcm/package/contents/ui/Screen.qml
67

Yea, I ignore the row for now. We can think about a different position for the button later on. I think it should be in one of the corners like it used to be.

ngraham added inline comments.Tue, Oct 29, 5:37 PM
kcm/package/contents/ui/Screen.qml
67

Why not remove the Row in this revision? You don't have to change the button position from where it is now, just remove the now-pointless Row.

Other that Nate's sensible comment, +1

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Nov 11, 9:18 PM
This revision was automatically updated to reflect the committed changes.
romangg marked 3 inline comments as done.
davidedmundson reopened this revision.Mon, Nov 11, 10:27 PM
This comment was removed by davidedmundson.
davidedmundson commandeered this revision.Mon, Nov 11, 10:28 PM
davidedmundson added a reviewer: romangg.

Edit, it was done. Just not reuploaded and approved in the correct order.
Try to do that.

commandeering just to close

davidedmundson abandoned this revision.Mon, Nov 11, 10:29 PM