feat(kcm): zoom preview automatically

Authored by davidedmundson on Oct 28 2019, 11:47 PM.



On output size and position changes reset the relative output position in the
overview automatically.

This way the outputs are always movable with ease and the "center view" button
is not necessary anymore.

Test Plan

Moved outputs in multi monitor environment. Overview zoomed automatically.

Diff Detail

R104 KScreen
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
romangg created this revision.Oct 28 2019, 11:47 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 28 2019, 11:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
romangg requested review of this revision.Oct 28 2019, 11:47 PM
ngraham added inline comments.

You don't need a Row here anymore because it now only contains one item; instead you can just position the Identify button manually.

romangg added inline comments.Oct 29 2019, 5:32 PM

Yea, I ignore the row for now. We can think about a different position for the button later on. I think it should be in one of the corners like it used to be.

ngraham added inline comments.Oct 29 2019, 5:37 PM

Why not remove the Row in this revision? You don't have to change the button position from where it is now, just remove the now-pointless Row.

Other that Nate's sensible comment, +1

This revision was not accepted when it landed; it landed in state Needs Review.Nov 11 2019, 9:18 PM
This revision was automatically updated to reflect the committed changes.
romangg marked 3 inline comments as done.
davidedmundson reopened this revision.Nov 11 2019, 10:27 PM
This comment was removed by davidedmundson.
davidedmundson commandeered this revision.Nov 11 2019, 10:28 PM
davidedmundson added a reviewer: romangg.

Edit, it was done. Just not reuploaded and approved in the correct order.
Try to do that.

commandeering just to close

davidedmundson abandoned this revision.Nov 11 2019, 10:29 PM