Differential D24992

KOrganizer Agenda View: Compute Grid Lines Color (Another idea)
AbandonedPublic
Actions

Authored by winterz on Oct 27 2019, 9:17 PM.

Details

Reviewers
mlaurent
Group Reviewers
VDG
Summary

here's another way to solve grid line coloring bug.

the idea is to set the grid line to black or white, as a function of contrasting to the agenda view non-working hours background color. I don't really like this as well since it doesn't consider the working hours background color.

Presumably the user picks a window text color that they can read against any working and non-working hour colors, which is why I think making a computation against any one background color (when we have several on display at the same time) is not a good idea.

Diff Detail

Repository
R210 KOrganizer
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Oct 27 2019, 9:17 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptOct 27 2019, 9:17 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
winterz requested review of this revision.Oct 27 2019, 9:17 PM
ognarb added a reviewer: VDG.Oct 27 2019, 11:54 PM
ognarb added a subscriber: ognarb.

Hmm I think depending on the user selection for a working hours color, we will never get a correct color for the line. :(

Either we try to find a good heuristic to find a good color for the lines that is correct in most of the common case, or we completely remove the possibility for the user to choose a color for the background and just follow the global color scheme. We could probably also add a setting for the line, but I don't think it's a good idea to add more settings.

Adding VDG for feedback

ngraham added a subscriber: ngraham.Oct 27 2019, 11:56 PM
In D24992#554988, @ognarb wrote:

completely remove the possibility for the user to choose a color for the background and just follow the global color scheme.

+1

winterz abandoned this revision.Nov 7 2019, 3:18 PM

Revision Contents
Changeset List

PathPackages
Msrc/agenda/agenda.cpp (36 lines)

Diff 68855

View Options

src/agenda/agenda.cpp

Loading...