Differential D24909

[PC3/button] Elide text always
ClosedPublic
Actions

Authored by davidedmundson on Oct 24 2019, 10:17 AM.

Details

Reviewers
apol
ngraham
Group Reviewers
Plasma
Commits
R242:12edce87bbd7: [PC3/button] Elide text always
Summary

We always want the label to have the width managed by the layout to fill
all available space.

Test Plan

In tests/components/button3.qml the test

"long text but constrained, should be 150px and elided" now is correctly
elided rather than the text spewing past the end of the button. The text
does not overlap the icon.

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 24 2019, 10:17 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
davidedmundson requested review of this revision.Oct 24 2019, 10:17 AM
apol accepted this revision.Oct 24 2019, 11:04 AM
This revision is now accepted and ready to land.Oct 24 2019, 11:04 AM
ngraham accepted this revision.Oct 24 2019, 5:01 PM
Closed by commit R242:12edce87bbd7: [PC3/button] Elide text always (authored by davidedmundson). · Explain WhyOct 25 2019, 2:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68753

View Options

src/declarativeimports/plasmacomponents3/Button.qml

Loading...