[sidebar] Add a hover effect to intro page icons
ClosedPublic

Authored by filipf on Wed, Oct 23, 9:12 PM.

Details

Summary

There is currently no hover effect on the intro page.

This patch makes the icons themselves produce the effect on mouse hover or active focus.

BUG: 413375
FIXED-IN: 5.17.2

Test Plan

Diff Detail

Repository
R124 System Settings
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
filipf created this revision.Wed, Oct 23, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptWed, Oct 23, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Wed, Oct 23, 9:12 PM
filipf edited the test plan for this revision. (Show Details)Wed, Oct 23, 9:13 PM
filipf added reviewers: Plasma, VDG, ngraham.
filipf updated this revision to Diff 68641.Wed, Oct 23, 9:18 PM

also make the effect appear on activeFocus (tabbing)

filipf edited the summary of this revision. (Show Details)Wed, Oct 23, 9:18 PM
ngraham accepted this revision.Wed, Oct 23, 9:19 PM

5.17

This revision is now accepted and ready to land.Wed, Oct 23, 9:19 PM
filipf edited the summary of this revision. (Show Details)Wed, Oct 23, 10:17 PM

5.17

Awesome. Leaving open for 24 hrs from submission time in case of extra comments, if not will land it then.

Is it possible to make a smooth effect animation? Like in sidebar.

Is it possible to make a smooth effect animation? Like in sidebar.

I think that require changes in Kirigami.Icon so not in this patch.

I wouldn't even be in favor of that, FWIW. I think the animated hover transitions in the sidebar are quite distracting, and inconsistent with the hover effects everywhere else. I'd like to make the hover effects instant, not animated.

This revision was automatically updated to reflect the committed changes.