Differential D24901

[sidebar] Add a hover effect to intro page icons
ClosedPublic
Actions

Authored by filipf on Oct 23 2019, 9:12 PM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
VDG
Commits
R124:a306b76cb853: [sidebar] Add a hover effect to intro page icons
R124:1f929dda539c: Merge branch 'Plasma/5.17'
Summary

There is currently no hover effect on the intro page.

This patch makes the icons themselves produce the effect on mouse hover or active focus.

BUG: 413375
FIXED-IN: 5.17.2

Test Plan

Diff Detail

Repository
R124 System Settings
Branch
hover-effect-intro-page-icons (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18094
Build 18112: arc lint + arc unit
filipf created this revision.Oct 23 2019, 9:12 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 23 2019, 9:12 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
filipf requested review of this revision.Oct 23 2019, 9:12 PM
filipf edited the test plan for this revision. (Show Details)Oct 23 2019, 9:13 PM
filipf added reviewers: Plasma, VDG, ngraham.
filipf updated this revision to Diff 68641.Oct 23 2019, 9:18 PM

also make the effect appear on activeFocus (tabbing)

filipf edited the summary of this revision. (Show Details)Oct 23 2019, 9:18 PM
ngraham accepted this revision.Oct 23 2019, 9:19 PM

5.17

This revision is now accepted and ready to land.Oct 23 2019, 9:19 PM
filipf edited the summary of this revision. (Show Details)Oct 23 2019, 10:17 PM
In D24901#553008, @ngraham wrote:

5.17

Awesome. Leaving open for 24 hrs from submission time in case of extra comments, if not will land it then.

• ghost34 added a subscriber: • ghost34.Oct 23 2019, 11:08 PM

Is it possible to make a smooth effect animation? Like in sidebar.

filipf added a comment.Oct 23 2019, 11:21 PM
In D24901#553055, @KonqiDragon wrote:

Is it possible to make a smooth effect animation? Like in sidebar.

I think that require changes in Kirigami.Icon so not in this patch.

ngraham added a comment.Oct 24 2019, 12:27 AM

I wouldn't even be in favor of that, FWIW. I think the animated hover transitions in the sidebar are quite distracting, and inconsistent with the hover effects everywhere else. I'd like to make the hover effects instant, not animated.

Closed by commit R124:a306b76cb853: [sidebar] Add a hover effect to intro page icons (authored by filipf). · Explain WhyOct 24 2019, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68641

View Options

sidebar/package/contents/ui/IntroIcon.qml

Loading...