Add KLocalizedString::untranslatedText
ClosedPublic

Authored by aacid on Oct 23 2019, 8:46 PM.

Details

Summary

returns the untraslated string of the KLocalizedString

Diff Detail

Repository
R249 KI18n
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 18087
Build 18105: arc lint + arc unit
aacid created this revision.Oct 23 2019, 8:46 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptOct 23 2019, 8:46 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
aacid requested review of this revision.Oct 23 2019, 8:46 PM
aacid added a subscriber: ilic.Oct 23 2019, 8:46 PM
ilic added a comment.Oct 24 2019, 11:33 AM

An apparent need for this functionality was popping up from time to time, but somehow never got too serious. Probably because each time it would have been just a convenience, since the original text could have been transported to where it is needed next to the KLocalizedString objects themselves. Is it then worthy of adding more API? I don't know.

However, if it is added, then there should exist also methods for retrieving the context and original plural strings.

aacid added a comment.Oct 24 2019, 9:42 PM

No one has shown the need for those things your asking.

We have clear need for untranlatedText.

aacid added a comment.Oct 30 2019, 6:24 PM

I'll commit this on saturday unless someone disagrees

ilic accepted this revision.Nov 2 2019, 3:18 AM
This revision is now accepted and ready to land.Nov 2 2019, 3:18 AM
ngraham added a subscriber: ngraham.Nov 2 2019, 3:26 AM

Makes sense to me.

aacid closed this revision.Nov 2 2019, 12:33 PM