Use a more correct and appropriate visual metaphor for "get hot new stuff" icon
ClosedPublic
Actions

Authored by ngraham on Oct 22 2019, 7:18 PM.

Details

Reviewers

leinir
ndavis

Group Reviewers

VDG

Commits

R266:dc13d172fdc8: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon

Summary

Right now it's a duplicate (not even a symlink) of the favorite icon, which is
semantically inaccurate. A more appropriate visual metaphor is "download", since that's
what GHNS will do. So this patch symlinks the GHNS icon to edit-download. This makes
it work for icons-only buttons as well, where the icon alone is sufficient to communicate
what will happen.

Thanks for @ndavis for suggesting this.

BUG: 400500
FIXED-IN: 5.64

Test Plan

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ngraham created this revision.Oct 22 2019, 7:18 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptOct 22 2019, 7:18 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ngraham requested review of this revision.Oct 22 2019, 7:18 PM

Harbormaster completed remote builds in B18050: Diff 68567.Oct 22 2019, 7:18 PM

ndavis accepted this revision.Oct 23 2019, 2:10 AM

This revision is now accepted and ready to land.Oct 23 2019, 2:10 AM

Closed by commit R266:dc13d172fdc8: Use a more correct and appropriate visual metaphor for "get hot new stuff" icon (authored by ngraham). · Explain WhyOct 23 2019, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M	M	icons-dark/actions/16/get-hot-new-stuff.svg (1 line)
M	M	icons-dark/actions/22/get-hot-new-stuff.svg (1 line)
M	M	icons-dark/actions/24/get-hot-new-stuff.svg (1 line)
M	M	icons/actions/16/get-hot-new-stuff.svg (1 line)
M	M	icons/actions/22/get-hot-new-stuff.svg (1 line)
M	M	icons/actions/24/get-hot-new-stuff.svg (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	68567	a51651f		Oct 22 2019, 7:18 PM	★	★
Diff 2	68583	a51651f	R266:dc13d172fdc889bc7c00df6829021eebf6769fd4	Oct 23 2019, 2:25 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
031fc051a99b	5a7ac418286e	a51651fd91a2	Nate Graham	Use a more correct and appropriate visual metaphor for "get hot new stuff" icon (Show More…)	Oct 22 2019, 7:16 PM