Differential D24861

Fix size of SpinBoxes
ClosedPublic
Actions

Authored by kmaterka on Oct 22 2019, 11:49 AM.

Details

Reviewers
martinkostolny
broulik
ngraham
Group Reviewers
Plasma
Commits
R885:2481a8eb6a22: Fix size of SpinBoxes
Summary

The numbers in the text entry box for "Manual Brightness Step" in the Redshift System Tray controller don't fit properly.

BUG: 413218

Test Plan
  1. right click on Redshift System Tray icon
  2. Click on "Configure Redshift Control

Observed:
Numbers in text entry box for "Manual Brightness Step" is cut off

Expected:
Numbers should be wholly visible.

Diff Detail

Repository
R885 Redshift Control for Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kmaterka created this revision.Oct 22 2019, 11:49 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 22 2019, 11:49 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kmaterka requested review of this revision.Oct 22 2019, 11:49 AM
ngraham added a subscriber: ngraham.Oct 22 2019, 4:32 PM
ngraham added inline comments.
package/contents/ui/config/ConfigGeneral.qml
64

Don't hardcode things like this; instead do Kirigami.Units.gridUnit * 4

kmaterka updated this revision to Diff 68558.Oct 22 2019, 4:48 PM

Do not use hardcoded values

kmaterka marked an inline comment as done.Oct 22 2019, 4:49 PM
kmaterka added inline comments.
package/contents/ui/config/ConfigGeneral.qml
64

OK, I made it the same width as IconPicker, it should look nice

ngraham accepted this revision.Oct 22 2019, 4:51 PM
This revision is now accepted and ready to land.Oct 22 2019, 4:51 PM
Closed by commit R885:2481a8eb6a22: Fix size of SpinBoxes (authored by kmaterka). · Explain WhyOct 22 2019, 5:04 PM
This revision was automatically updated to reflect the committed changes.
kmaterka marked an inline comment as done.

Revision Contents
Changeset List

Diff 68561

View Options

CMakeLists.txt

Loading...
View Options

package/contents/ui/config/ConfigGeneral.qml

Loading...