[Applet] Make spinboxes editable
ClosedPublic

Authored by ngraham on Mon, Oct 21, 2:00 AM.

Details

Summary

Otherwise you can't enter numbers in them and it's really annoying

Test Plan

Now you can change the max volume and volume step spinboxes without raising your
blood pressure

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Mon, Oct 21, 2:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMon, Oct 21, 2:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Mon, Oct 21, 2:00 AM

Does it also need a valueFromText function then?

ndavis accepted this revision.Mon, Oct 21, 7:05 AM
This revision is now accepted and ready to land.Mon, Oct 21, 7:05 AM

Yeah, we probably should allow any spinboxes with a large range to be editable. I can't actually think of a reason why they shouldn't always be editable unless the increments have to have a specific fraction.

ngraham updated this revision to Diff 68460.Mon, Oct 21, 4:58 PM

Add valueForText handlers

This revision was automatically updated to reflect the committed changes.