Differential D24816

[Applet] Make spinboxes editable
ClosedPublic
Actions

Authored by ngraham on Oct 21 2019, 2:00 AM.

Details

Reviewers
ndavis
Group Reviewers
VDG
Plasma
Commits
R115:e1a2940de814: [Applet] Make spinboxes editable
Summary

Otherwise you can't enter numbers in them and it's really annoying

Test Plan

Now you can change the max volume and volume step spinboxes without raising your
blood pressure

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 21 2019, 2:00 AM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 21 2019, 2:00 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 21 2019, 2:00 AM
broulik added a subscriber: broulik.Oct 21 2019, 6:31 AM

Does it also need a valueFromText function then?

ndavis accepted this revision.Oct 21 2019, 7:05 AM
This revision is now accepted and ready to land.Oct 21 2019, 7:05 AM
ndavis added a comment.Oct 21 2019, 7:08 AM

Yeah, we probably should allow any spinboxes with a large range to be editable. I can't actually think of a reason why they shouldn't always be editable unless the increments have to have a specific fraction.

ngraham updated this revision to Diff 68460.Oct 21 2019, 4:58 PM

Add valueForText handlers

Closed by commit R115:e1a2940de814: [Applet] Make spinboxes editable (authored by ngraham). · Explain WhyOct 21 2019, 4:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 68461

View Options

applet/contents/ui/ConfigGeneral.qml

Loading...