Drop setOpaqueResize() call in konqframecontainer, let the style use
its defaults.
Remove some spurious #include's
Don't setFont() on widgets, let the widget/style handle it
Details
Details
Diff Detail
Diff Detail
- Repository
- R226 Konqueror
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| CMakeLists.txt | ||
|---|---|---|
| 29 | I'll merge the first two ones. As for kdelibs4support, having it in a separate find_package makes it easier to comment out one line while building locally to find out what code still needs porting away from kdelibs4support. | |
| src/konqview.cpp | ||
| 1227 | I think this whole method can go away, I'll do that in a separate diff. | |
| src/konqmainwindow.cpp | ||
|---|---|---|
| 221 | setComponentData is a non-deprecated method in KParts::PartBase (which the mainwindow inherits from). We need to call it, what happens in main() won't end up triggering the code in PartBase. I think you just need to replace KComponentData::mainComponent() with KAboutData::applicationData() | |
| 430 | Given the if(), we also get in the else if the file is local and exists, which seems wrong. You probably want to split up the if() in order to have the exists() call in a nested if() statemend. | |
| 431 | you should also do job->setSide(KIO::StatJob::DestinationSide); to preserve this logic from the old NetAccess call. | |
| 434 | exec() returns bool, so you could just do nameFilter = !job->exec() ? fileName : QString(); | |
Comment Actions
Fix if() loop totally wrong logic
setComponentData() is not deprecated for KParts
When replacing KIO::NetAccess::exists() better use a stat job with KIO::StatJob::DestinationSide
Use job->exec() directly as it returns a bool