[kcms/nightcolor] Add hints to temperature slider direction
ClosedPublic

Authored by davidedmundson on Fri, Oct 18, 4:00 PM.

Details

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Fri, Oct 18, 4:00 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Oct 18, 4:00 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Fri, Oct 18, 4:00 PM
ngraham requested changes to this revision.Fri, Oct 18, 4:03 PM
ngraham added a subscriber: ngraham.

Nice.

kcms/nightcolor/package/contents/ui/main.qml
151

This should be "Cool" (the color pairs are "hot/cold" and "warm/cool"; mixing them is a bit weird))

This revision now requires changes to proceed.Fri, Oct 18, 4:03 PM

Made the patch even cooler

ngraham accepted this revision.Fri, Oct 18, 4:05 PM

Fixit then shipit!

kcms/nightcolor/package/contents/ui/main.qml
153

Oh and one more thing, this should probably be a vertical spacer so the labels look grouped with the slider.

This revision is now accepted and ready to land.Fri, Oct 18, 4:05 PM

In right to left layout the labels must be swapped.

Nevermind I am an idiot and don't know how (colo(u)r) temperature works.

Nevermind I am an idiot and don't know how (colo(u)r) temperature works.

Which is exactly why we need these labels. :)

This revision was automatically updated to reflect the committed changes.