| ervin | |
| broulik |
| Plasma |
When we create a KQuickAddons::ConfigModule in the factory we didn't
set a parent. It is passed to the wrapper KCModuleQML, and even though
the wrapper is memory manager the ConfigModule object itself was not.
This lead to another crash as the KAboutData is deleted twice, which was
fixed with an explicit copy
BUG: 412998
qDebug inside the colours KCM destructor
It now appears when changing tabs
| No Linters Available |
| No Unit Test Coverage |
| Buildable 17789 | |
| Build 17807: arc lint + arc unit |
Slightly refactor so the teardown order deletes the QML content and then
deletes the parent window which is a bit more logical.
Now kscreen KCM doesn't crash even with the extra prompts
| src/kcmoduleloader.cpp | ||
|---|---|---|
| 101 ↗ | (On Diff #68096) | Easier fix is likely to wrap that into a std::unique_ptr here and calling release() on it when creating the KCModuleQml later on. Would be even better to change KCModuleQml to take a std::unique_ptr in the ctor and use a unique_ptr internally (AFAICT it's not public API so doable). That's admittedly more intrusive change though but at least would make some of that ownership issues more explicit and easier to track. |
| 107 ↗ | (On Diff #68096) | This is unreachable code. You want to delete before the reportError call but after the cm->errorString() call. |
Looks good to me, I'll accept it but better wait a bit in case others want to chip in.