Differential D24713

[Updates page] use fancier logic for handling elided Old+New version strings
ClosedPublic
Actions

Authored by ngraham on Oct 16 2019, 8:54 PM.

Details

Reviewers
apol
broulik
Group Reviewers
Discover Software Store
Commits
R134:bbc88da3f93c: [Updates page] use fancier logic for handling elided Old+New version strings
Summary

@broulik taught me how to do this! It's more robust than the current logic, which
doesn't expand to the full form when the window becomes wide enough to show the
whole string without eliding.

Test Plan

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Oct 16 2019, 8:54 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 16 2019, 8:54 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Oct 16 2019, 8:54 PM
ngraham updated this revision to Diff 68098.Oct 16 2019, 11:25 PM

Make it display

mart added a subscriber: mart.Oct 17 2019, 9:29 AM
mart added inline comments.
discover/qml/UpdatesPage.qml
277–281

this is very interesting and a good idea..
are you sure tough it doesn't cause binding loops?
i am trying to use the same in another thing and i can't seem to get rid of them

ngraham retitled this revision from [RFC] [Updates page] use fancier logic for handling elided Old+New version strings to [Updates page] use fancier logic for handling elided Old+New version strings.Oct 17 2019, 5:30 PM
ngraham edited the test plan for this revision. (Show Details)
ngraham updated this revision to Diff 68180.Oct 17 2019, 5:33 PM
ngraham marked an inline comment as done.

Fix binding loop

apol accepted this revision.Oct 17 2019, 5:51 PM
This revision is now accepted and ready to land.Oct 17 2019, 5:51 PM
Closed by commit R134:bbc88da3f93c: [Updates page] use fancier logic for handling elided Old+New version strings (authored by ngraham). · Explain WhyOct 17 2019, 6:16 PM
This revision was automatically updated to reflect the committed changes.
ratijas added a subscriber: ratijas.Feb 18 2023, 11:19 AM
ratijas added inline comments.
discover/qml/UpdatesPage.qml
262

WAAAAAT

how that is supposed to work

ratijas added inline comments.Feb 18 2023, 2:33 PM
discover/qml/UpdatesPage.qml
262

OK, so that's a "multi-length string" feature using Unicode "String Terminator" character U009C, as described in QtQuick documentation: https://doc.qt.io/qt-6/qml-qtquick-text.html#elide-prop

This still does not explain why does it need different eliding modes in ternary expression

Revision Contents
Changeset List

PathPackages
Mdiscover/qml/UpdatesPage.qml (26 lines)

Diff 68183

View Options

discover/qml/UpdatesPage.qml

Loading...